Remove openFile entirely to avoid latent problems with stream copy semantics.

Several classes and functions were not const-correct. Did the minimal changes
to fix compilation, although there are other const fixes that can be done.

- replaced for_each with range-based for loop
- added missing std:: scope
- for-loop temp now declared outside the loop to be in scope
- removed casts in calls to trim()