This commit increase warning level from `W3` to `W4` on MSVC and sets
warnings as errors. Exclusion is made for a specific warning (C4189).

Using `-pedantic` threw warnings on `g++`. This commit cleans up those
warnings.

This commit adds an option to build using CMake by adding
CMakeLists.txt. CMake builds are consistent with the builds currently
produced.

For Linux build, CPack produces artifacts consistent with the current
RPM specification.

CMake is also added to the CI pipeline in main.yml.

* Use "nullptr" instead of "NULL"

* Cosmetic fix

* bind2nd() and ptr_fun<>() is removed since C++17

bind2nd() and ptr_fun<>() are deprecated in C++11, and removed in C++17.
These functions are not available in LLVM's "libc++".
Use C++11 lambda expressions for them.

* Break long lines

* Add missing header for std::iswspace()

* Fix warning about the array delete

* Fix ErrorCode enum

* Fixing unintalized vars

* Fix warnings pertaining to EncodingType.

* More fixes to enum related warnings

* Enable warnings

* Work without "-fpermissive" option

* Cosmetic fix

* Add "const" to fix warnings

These strings are not needs to modify.

* No need to use "#pragma once" in main C++ source file

* Cosmetic fix

Add newline to end

* Return nullptr if error

* delete() not works for "void*"

Cast specific type to use delete()

* Disable VC++ specific pragmas for other C++ compilers

* Fix warning

* Fix warning

* Use pipeline for compiler

* Enable code optimization

* Add "default:" to fix "switch" syntax warning

* Use "nullptr" for null pointer

* Use nullptr instead of NULL

* Use nullptr instead of NULL

* Use "L" notation for wide character

* Use C++ header instead of raw C header

* Fix weights not being set in PictAddParameter()

* Change add param to only fill values if param != NULL

* Makefile: add clean target

While working on pict, it's useful to get a clean state.  This clean
target removes the target binary and output generated by a self test
execution (make test).

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* Makefile: allow parallelization of build

The current rule for building pict is based on a single command
execution, which makes faster builds leveraging parallel execution
impossible.

This change introduces the objects that are required to build pict,
and relies on implicit rules to turn the ".cpp" files into the object
files.

After these changes, a command such as "make -j8" shows the benefits
of this change.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* api/pictapi.h: use default calling convention when using gcc

gcc doesn't understand the __stdcall calling convention.  Let's
use its default when using it as a compiler.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* Makefile: relax a bit more the compiler options

I reckon that pict should be compiled with all warnings enabled,
and all warnings being treated as errors.  This is actually the goal
of other changes to be proposed soon.

For now, some code, such as naming attributes with the same name as
previously declared types is not really welcomed by some compilers
such as GCC, being considered "nonconformant code".

Since changes to fix this would bring changes to the pict API, let's
keep things simple and simply allow the unchanged code to build on
other compilers such as GCC.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* Makefile: use default compiler set on system

Users can choose selected compiler by setting the "CXX" environment
variable or by editting the Makefile.

Let's not hardcode a particular compiler, now that both clang and gcc
can be used to compile pict.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* Makefile: make test depend on target being built

Signed-off-by: Cleber Rosa <crosa@redhat.com>

* Makefile: add source target

It's useful to generate a snapshot of the current state of the GIT
repo.  Let's add a target that generates a tarball using git-archive
using a naming convention that makes it easy to trace to the commit
that generated this snapshot.

This format also happens to be well suitable for using the source
tarball when packaging it in RPM format.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

The 'inline' declaration was preventing it from being exported.

- replaced for_each with range-based for loop
- added missing std:: scope
- for-loop temp now declared outside the loop to be in scope
- removed casts in calls to trim()