From 5589037919f3fbd5b01d19ed360e39a2dbda1a36 Mon Sep 17 00:00:00 2001
From: qykth-git <14939671+qykth-git@users.noreply.github.com>
Date: Thu, 12 Aug 2021 04:50:10 +0900
Subject: [PATCH] Revert from multi-byte I/O to UTF-8 I/O (#61)
Multi-byte I/O dose too match for text input in some locale.
For example, "," in numbers treat as decimal separator, not word separator.
This makes "1,234" as "1234", not "1" and "234".
Use "C.UTF-8" to avoid this problem.
---
cli/pict.cpp | 4 ++--
doc/pict.md | 6 ------
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/cli/pict.cpp b/cli/pict.cpp
index d1b0770..2f759f3 100644
--- a/cli/pict.cpp
+++ b/cli/pict.cpp
@@ -129,8 +129,8 @@ int main
IN char* args[]
)
{
- // Use current locale name for multi-byte character I/O everywhare
- std::locale::global(std::locale(""));
+ // Use UTF-8 for multi-byte character I/O everywhare
+ std::locale::global(std::locale("C.UTF-8"));
// convert all args to wchar_t's
wchar_t** wargs = new wchar_t*[ argc ];
diff --git a/doc/pict.md b/doc/pict.md
index 7edb6d4..97de18a 100644
--- a/doc/pict.md
+++ b/doc/pict.md
@@ -66,12 +66,6 @@ A comma is the default separator but you can specify a different one using **/d*
By default, PICT generates a pair-wise test suite (all pairs covered), but the order can be set by option **/o** to a value larger than two. For example, if **/o:3** is specified, the test suite will cover all triplets of values thereby producing a larger number of tests but potentially making the test suite even more effective. The maximum order for a simple model is equal to the number of parameters, which will result in an exhaustive test suite. Following the same principle, specifying **/o:1** will produce a test suite that merely covers all values (combinations of 1).
-Note: On Unix/Linux environment, input/output file encoding depends on your locale settings. For example, if you want to use UTF-8 encoding, set environment variable **LANG** or **LC_CTYPE** to UTF-8 capable locale like **C.UTF-8**.
-
-Example:
-
- $ LC_CTYPE="C.UTF-8" pict utf8-input.txt
-
## Output Format
All errors, warning messages, and the randomization seed are printed to the error stream. The test cases are printed to the standard output stream. The first line of the output contains names of the parameters. Each of the following lines represents one generated test case. Values in each line are separated by a tab. This way redirecting the output to a file creates a tab-separated value format.
--
GitLab