Nantes Université

Skip to content

Project-Risk-A : refactor com/risk/view/impl/swing/SwingAttackView.java

Code smells in file :

  • Avoid unused private fields such as 'noOfTroopsLabel' : line 82
  • Unnecessary qualifier 'JFrame': 'WindowConstants::EXIT_ON_CLOSE' is already in scope because it is inherited by an enclosing type : line 143
  • Unnecessary qualifier 'IAttackView': 'ACTION_NEXT' is already in scope because it is inherited by an enclosing type : line 170
  • Unnecessary qualifier 'IAttackView': 'ACTION_SAVE' is already in scope because it is inherited by an enclosing type : line 173
  • Unnecessary qualifier 'IAttackView': 'ACTION_MOVE' is already in scope because it is inherited by an enclosing type : line 176
  • Unnecessary qualifier 'IAttackView': 'ACTION_SINGLE' is already in scope because it is inherited by an enclosing type : line 179
  • Unnecessary qualifier 'IAttackView': 'ACTION_ALLOUT' is already in scope because it is inherited by an enclosing type : line 182
  • Avoid unused local variables such as 'mediumFont' : line 205
  • Avoid unused local variables such as 'smallFont' : line 206
  • This if statement could be combined with its parent : line 228-230
  • Useless parentheses : line 237/260/291/312
  • Unnecessary qualifier 'IAttackView': 'ACTION_ATTACK_COUNTRY_CHANGED' is already in scope because it is inherited by an enclosing type : line 402
  • Unnecessary qualifier 'IAttackView': 'ACTION_DEFEND_COUNTRY_CHANGED' is already in scope because it is inherited by an enclosing type : line 406